mkimage: fit: check cmd string for buffer overflow #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating the command to create the fit image the inputs are file paths which can overflow the buffer. snprintf was being used to avoid the overflow itself but nothing actually checks if a truncation occured giving unexpected filenames causing following stages to fail. Therefore add some checks before attempting to run the command. Additionally have bumped up the size of the buffer as the current inputs can easily get truncated with long paths. Signed-off-by: Ian Pozella <[email protected]>
mtusnio
approved these changes
Nov 4, 2016
Shpinkso
approved these changes
Nov 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the command to create the fit image the inputs are
file paths which can overflow the buffer. snprintf was being used to
avoid the overflow itself but nothing actually checks if a
truncation occured giving unexpected filenames causing following
stages to fail.
Therefore add some checks before attempting to run the command.
Additionally have bumped up the size of the buffer as the current
inputs can easily get truncated with long paths.
Signed-off-by: Ian Pozella [email protected]